Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hint about a possible update failure reason #225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

strugee
Copy link
Contributor

@strugee strugee commented Apr 8, 2020

This feels ugly because it doesn't fix the underlying bug, but
it's incredibly hard to trace down the root cause in this
situation and it causes updates to fail which is pretty
critical. So this is probably better than nothing.

Ref QubesOS/qubes-issues#5052

This feels ugly because it doesn't fix the underlying bug, but
it's incredibly hard to trace down the root cause in this
situation and it causes updates to fail which is pretty
critical. So this is probably better than nothing.

Ref QubesOS/qubes-issues#5052
@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #225 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #225   +/-   ##
=======================================
  Coverage   72.65%   72.65%           
=======================================
  Files           3        3           
  Lines         512      512           
=======================================
  Hits          372      372           
  Misses        140      140           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b02dd6a...dbc2d73. Read the comment docs.

@marmarek
Copy link
Member

marmarek commented Apr 8, 2020

IMO better than guessing, make the actual error easier to find. It should be written to /var/lib/qubes/updates/errors in dom0, so qubes-dom0-update script may check this file and show it to the user. If that still doesn't contain enough details, you can modify qubes-receive-updates script to save stderr of qfile-dom0-unpacker there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants