Improved Manager Icons

[marmarta]

Result of audit/icon design by Ura Design.

Remaining minor quibble: should we replace all standard ok/cancel icons? The default icon set is kind of an acquired taste.

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 65.67%. Comparing base (afc1365) to head (69f2bb8).

Files with missing lines	Patch %	Lines
qubesmanager/qube_manager.py	80.00%	4 Missing ⚠️
qubesmanager/backup.py	0.00%	2 Missing ⚠️
qubesmanager/restore.py	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   65.82%   65.67%   -0.16%     
==========================================
  Files          18       18              
  Lines        3901     3892       -9     
==========================================
- Hits         2568     2556      -12     
- Misses       1333     1336       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[qubesos-bot]

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025012815-4.3&flavor=pull-requests

Test run included the following:

• Improved Icons and UX qubes-desktop-linux-manager#242 (QubesOS/qubes-desktop-linux-manager@476e758)
• Improved Manager Icons #403 (69f2bb8)
• Improved icons qubes-artwork#47 (QubesOS/qubes-artwork@0356747)

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111705-4.3&flavor=update

• system_tests_basic_vm_qrexec_gui

  • TC_30_Gui_daemon: test_002_clipboard_300k (failure)
    : Clipboard copy operation failed - content...

• system_tests_extra

  • TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0

• system_tests_dispvm

  • TC_20_DispVM_fedora-41-xfce: test_020_gui_app (error + cleanup)
    raise TimeoutError from exc_val... TimeoutError

  • TC_20_DispVM_fedora-41-xfce: test_100_open_in_dispvm (failure)
    AssertionError: './open-file test.txt' failed with ./open-file test...

• system_tests_kde_gui_interactive

  • gui_filecopy: unnamed test (unknown)

  • gui_filecopy: Failed (test died)
    # Test died: no candidate needle with tag(s) 'files-move-to-other' ...

  • gui_filecopy: wait_serial (wait serial expected)
    # wait_serial expected: qr/2E8vz-\d+-/...

• system_tests_gui_tools@hw7

  • desktop_linux_manager_create_qube: unnamed test (unknown)

  • desktop_linux_manager_create_qube: Failed (test died)
    # Test died: no candidate needle with tag(s) 'new-qube-launch-setti...

  • desktop_linux_manager_create_qube: unnamed test (unknown)

Failed tests

10 failures

• system_tests_basic_vm_qrexec_gui

  • TC_30_Gui_daemon: test_002_clipboard_300k (failure)
    : Clipboard copy operation failed - content...

• system_tests_extra

  • TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0

• system_tests_dispvm

  • TC_20_DispVM_fedora-41-xfce: test_020_gui_app (error + cleanup)
    raise TimeoutError from exc_val... TimeoutError

  • TC_20_DispVM_fedora-41-xfce: test_100_open_in_dispvm (failure)
    AssertionError: './open-file test.txt' failed with ./open-file test...

• system_tests_kde_gui_interactive

  • gui_filecopy: unnamed test (unknown)

  • gui_filecopy: Failed (test died)
    # Test died: no candidate needle with tag(s) 'files-move-to-other' ...

  • gui_filecopy: wait_serial (wait serial expected)
    # wait_serial expected: qr/2E8vz-\d+-/...

• system_tests_gui_tools@hw7

  • desktop_linux_manager_create_qube: unnamed test (unknown)

  • desktop_linux_manager_create_qube: Failed (test died)
    # Test died: no candidate needle with tag(s) 'new-qube-launch-setti...

  • desktop_linux_manager_create_qube: unnamed test (unknown)

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/119126#dependencies

4 fixed

• system_tests_extra

  • TC_00_QVCTest_whonix-gateway-17: test_010_screenshare (failure)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0

• system_tests_kde_gui_interactive

  • gui_keyboard_layout: Failed (test died)
    # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

• system_tests_basic_vm_qrexec_gui_zfs

  • switch_pool: Failed (test died)
    # Test died: command 'dnf install -y ./zfs-release.rpm' failed at /...

• system_tests_audio@hw1

  • TC_20_AudioVM_PipeWire_whonix-workstation-17: test_260_audio_mic_enabled_switch_audiovm (failure)
    AssertionError: too short audio, expected 10s, got 0.00013605442176...

Unstable tests

• system_tests_basic_vm_qrexec_gui_zfs

  TC_00_Basic/test_120_start_standalone_with_cdrom_dom0 (1/5 times with errors)

  • job 109480 AssertionError: 1 != 0 : b'Timeout waiting for dom0:loop6 device to...