Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ubuntu 15.10 #193

Merged
merged 1 commit into from
Jan 11, 2016
Merged

Update to ubuntu 15.10 #193

merged 1 commit into from
Jan 11, 2016

Conversation

imshashank
Copy link
Contributor

Update to get new golang

Fixes the bug when building the docker image.

Step 9 : RUN go get github.com/tools/godep &&     go get -t github.com/smartystreets/goconvey &&     go build &&     ln -s /opt/go/src/github.com/QubitProducts/bamboo /var/bamboo &&     mkdir -p /run/haproxy &&     mkdir -p /var/log/supervisor
 ---> Running in 4f034c6ddb5a

# github.com/QubitProducts/bamboo

./bamboo.go:185: client.Timeout undefined (type *http.Client has no field or method Timeout)

The command '/bin/sh -c go get github.com/tools/godep &&     go get -t github.com/smartystreets/goconvey &&     go build &&     ln -s /opt/go/src/github.com/QubitProducts/bamboo /var/bamboo &&     mkdir -p /run/haproxy &&     mkdir -p /var/log/supervisor' returned a non-zero code: 2

Update to get new golang
@imshashank
Copy link
Contributor Author

Fixes the Issue #192

@j1n6
Copy link
Contributor

j1n6 commented Jan 9, 2016

Thank you for PR. We usually recommend using Ubuntu LTS releases for the build.
I can see there's a need to build on 15.10. It might make sense to create a separate Dockerfile for another Docker build.

@lclarkmichalek
Copy link
Contributor

I'm pretty OK with this, seeing as 16.04 is just around the corner, and we can update to LTS then. Another option might be using godeb to install a specific go version, or using the official golang image.

@imshashank
Copy link
Contributor Author

It makes sense to change this to 15.10 from 14.04 instead of creating a new file as the docker image did not get build at all. So the Dockerfile is kind of broken.

j1n6 pushed a commit that referenced this pull request Jan 11, 2016
@j1n6 j1n6 merged commit fd0bf37 into QubitProducts:master Jan 11, 2016
@j1n6
Copy link
Contributor

j1n6 commented Jan 11, 2016

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants