Flag LRM-compliant output variables in adms data tree #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per issue Qucs#72, the implicit rules in adms.implicit.xml only flag a variable in the data tree with "output=yes" in the data tree if they have the attribute 'ask="yes"'. The LRM (Verilog-AMS LRM version 2.4, section 3.2.1) says that module-scoped variables with either "desc" or "units" attributes should be designated as output variables. This commit modifies adms.implicit.xml to set the "output" field of the data tree to "yes" if the variable is not an input variable (parameter) and is module scoped, and if it has either a "desc" or a "units" (or both) attribute. The Xyce team has been using a patched adms.implicit.xml with this modification for a couple of years, and I had simply forgotten that I'd opened issue Qucs#72 asking that it be done in ADMS itself. Qucs#72
tvrusso
force-pushed
the
topic-issue-72
branch
from
956e439 to
25cc155
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue #72, the implicit rules in adms.implicit.xml only flag a variable in the data tree with "output=yes" in the data tree if they have the attribute 'ask="yes"'.
The LRM (Verilog-AMS LRM version 2.4, section 3.2.1) says that module-scoped variables with either "desc" or "units" attributes should be designated as output variables.
This commit modifies adms.implicit.xml to set the "output" field of the data tree to "yes" if the variable is not an input variable (parameter) and is module scoped, and if it has either a "desc" or a "units" (or both) attribute.
The Xyce team has been using a patched adms.implicit.xml with this modification for a couple of years, and I had simply forgotten that I'd opened issue #72 asking that it be done in ADMS itself.
#72