feat(next-international): added cookieName and headerName options
#360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@valentinpolitov is attempting to deploy a commit to the Tom Labs Team on Vercel. A member of the Team first needs to authorize it. |
… to middleware config
valentinpolitov
force-pushed
the
feat/custom-names
branch
from
c9f78f8
to
d11b9d7
Compare
|
Thanks for this PR! I'd like to include it in the V2, so we'll wait a bit before merging: #359 |
|
Would love to use this. Any date for when V2 will be released? |
|
This option would be wonderful, but it should also include options for the cookie. Right now it's configured as SameSite=Strict which will result in ignoring the cookie on redirect. / -> will always go to locale from Accept-Language/or result of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
cookieNameandheaderNameoptions to middleware configcloses #305