Skip to content

Commit

Permalink
style: minor TODOs done
Browse files Browse the repository at this point in the history
  • Loading branch information
giannipetrella committed Jan 19, 2025
1 parent 842f5a4 commit 1d8b8f6
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 15 deletions.
1 change: 0 additions & 1 deletion src/Bundles.jl
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ julia> chern_character(tdd)
```
"""
function dual(F::Bundle)
# TODO Implement Teleman weight manipulation
if _has_chern_data(F)
new = Bundle(F.parent, adams(F, -1))
else
Expand Down
22 changes: 8 additions & 14 deletions src/Moduli.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1512,10 +1512,7 @@ function chern_character_line_bundle(
eta::AbstractVector{Int},
)
x = chern_class_line_bundle(M, eta)
# TODO why assign this and then return it?
chern_character = sum(x^i / factorial(i) for i in 0:dimension(M))

return chern_character
return sum(x^i / factorial(i) for i in 0:dimension(M))
end

"""
Expand Down Expand Up @@ -1552,9 +1549,7 @@ function total_chern_class_universal(
)
CH = chow_ring(M)
CHvars = gens(CH)
# TODO why assign it and then return it?
cUi = sum(CHvars[sum(M.d[1:(i - 1)]) + r] for r in 1:M.d[i]; init=CH(0)) + CH(1)
return cUi
return sum(CHvars[sum(M.d[1:(i - 1)]) + r] for r in 1:M.d[i]; init=CH(0)) + CH(1)
end

"""
Expand Down Expand Up @@ -1863,8 +1858,7 @@ function dimension(M::QuiverModuliStack)
if is_nonempty(M)
return -euler_form(M.Q, M.d, M.d)
end
# TODO why return a string, instead of -Inf?
return "-∞"
return -Inf
end

"""
Expand Down Expand Up @@ -1896,7 +1890,7 @@ function dimension(M::QuiverModuliSpace)
if M.condition == "semistable"
return 0
else
return "-∞"
return -Inf
end
end

Expand All @@ -1908,7 +1902,7 @@ function dimension(M::QuiverModuliSpace)
# if the stable locus is empty, the dimension is the maximum of the dimensions
# of the Luna strata
if M.condition == "stable"
return "-∞"
return -Inf
elseif M.condition == "semistable"
if has_semistables(M.Q, M.d, M.theta)
return maximum(
Expand All @@ -1918,7 +1912,7 @@ function dimension(M::QuiverModuliSpace)
end
end
# the semistable locus is also empty
return "-∞"
return -Inf
end

"""
Expand Down Expand Up @@ -2018,9 +2012,9 @@ function is_projective(M::QuiverModuli)

SSP = semisimple_moduli_space(M)
if M.condition == "semistable"
return dimension(SSP) in [0, "-∞"]
return dimension(SSP) in [0, -Inf]
elseif M.condition == "stable"
return dimension(SSP) in [1, "-∞"] && semistable_equals_stable(M)
return dimension(SSP) in [1, -Inf] && semistable_equals_stable(M)
end
end

Expand Down

0 comments on commit 1d8b8f6

Please sign in to comment.