feat: crash on reporter init error

QuokkaStake · Oct 19, 2023 · 212a9f3 · 212a9f3
1 parent b27cf2b
commit 212a9f3
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/pkg/app.go b/pkg/app.go
@@ -60,7 +60,9 @@ func (a *App) Start() {
 	a.MutesManager.Load()
 
 	for _, reporter := range a.Reporters {
-		reporter.Init()
+		if err := reporter.Init(); err != nil {
+			a.Logger.Fatal().Err(err).Str("name", reporter.Name()).Msg("Error initializing reporter")
+		}
 		if reporter.Enabled() {
 			a.Logger.Info().Str("name", reporter.Name()).Msg("Init reporter")
 		}

diff --git a/pkg/reporters/pagerduty/pagerduty.go b/pkg/reporters/pagerduty/pagerduty.go
@@ -120,7 +120,8 @@ func NewPagerDutyReporter(config config.PagerDutyConfig, logger *zerolog.Logger)
 	}
 }
 
-func (r Reporter) Init() {
+func (r Reporter) Init() error {
+	return nil
 }
 
 func (r Reporter) Enabled() bool {

diff --git a/pkg/reporters/reporter.go b/pkg/reporters/reporter.go
@@ -5,7 +5,7 @@ import (
 )
 
 type Reporter interface {
-	Init()
+	Init() error
 	Enabled() bool
 	SendReport(report Report) error
 	Name() string

diff --git a/pkg/reporters/telegram/telegram.go b/pkg/reporters/telegram/telegram.go
@@ -50,10 +50,10 @@ func NewTelegramReporter(
 	}
 }
 
-func (reporter *Reporter) Init() {
+func (reporter *Reporter) Init() error {
 	if reporter.TelegramToken == "" || reporter.TelegramChat == 0 {
 		reporter.Logger.Debug().Msg("Telegram credentials not set, not creating Telegram reporter.")
-		return
+		return nil
 	}
 
 	bot, err := tele.NewBot(tele.Settings{
@@ -63,7 +63,7 @@ func (reporter *Reporter) Init() {
 
 	if err != nil {
 		reporter.Logger.Warn().Err(err).Msg("Could not create Telegram bot")
-		return
+		return err
 	}
 
 	bot.Handle("/start", reporter.HandleHelp)
@@ -74,6 +74,8 @@ func (reporter *Reporter) Init() {
 
 	reporter.TelegramBot = bot
 	go reporter.TelegramBot.Start()
+
+	return nil
 }
 
 func (reporter *Reporter) Enabled() bool {