Skip to content

Commit

Permalink
bump web components version
Browse files Browse the repository at this point in the history
This web components bump includes fixes for verification grid result
downloads by calling toJSON on subject models.

This commit also removes the hacky stringification of tag names in the
workbench client as the web components can now handle an array of tags

Fixes: #2168
  • Loading branch information
hudson-newey committed Nov 14, 2024
1 parent 8909001 commit c78bcbb
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 11 deletions.
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"@angular/platform-server": "17.1.2",
"@angular/router": "17.1.2",
"@angular/ssr": "^17.1.2",
"@ecoacoustics/web-components": "^1.2.2",
"@ecoacoustics/web-components": "^1.2.5",
"@fortawesome/angular-fontawesome": "^0.14.1",
"@fortawesome/fontawesome-svg-core": "^6.1.1",
"@fortawesome/free-solid-svg-icons": "^6.1.1",
Expand Down
8 changes: 2 additions & 6 deletions src/app/services/models/annotation.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,12 @@ export class AnnotationService {
) {}

public async show(audioEvent: AudioEvent): Promise<Annotation> {
const tags = await this.showTags(audioEvent);
const audioEventTags = await this.showTags(audioEvent);
const audioRecording = await this.showAudioRecording(audioEvent);

// TODO: this is a tempoary patch for ecoacoustics/web-components#213
// until it is fixed upstream
const tagDescriptor = tags.map((tag) => tag.text).join(", ");

const data = {
...audioEvent,
tags: tagDescriptor,
tags: audioEventTags,
audioRecording,
};

Expand Down

0 comments on commit c78bcbb

Please sign in to comment.