Fix incorrect target for hidden copy component #2205
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect target for hidden copy component
There was previously a bug where the touch target for the
HiddenCopyComponent
was the copy icon, not the copy button.This is was exacerbated by the fact that there were no unit tests to assert that this component would copy text correctly.
Changes
HiddenCopyCompont
's copy touch target to the copy button instead of the copy iconIssues
Fixes: #2146
Visual Changes
Should be unchanged, let me know if you see any discrepancies
Final Checklist
npm run lint
)npm run test:all
)