Create read interface for analysis jobs #2206
Conversation
hudson-newey
added
enhancement
|
Size Change: +2.03 kB (+0.05%) Total Size: 3.91 MB
ℹ️ View Unchanged
|
hudson-newey
changed the title
| label: "Analysis Jobs", | ||
| label: "Audio Analysis", |
There was a problem hiding this comment.
why the label change? Analysis Jobs was accurate
There was a problem hiding this comment.
Discussed offline, I will revert this change
There was a problem hiding this comment.
For consistency, chaning this admin.menu label also means that the analysis-jobs.menu label has also been changed to "Analysis Jobs"
| const filterByProject: Filters<AnalysisJob> = { | ||
| filter: { | ||
| or: { | ||
| projectId: { eq: this.project?.id }, |
There was a problem hiding this comment.
probably shouldn't include this filter condition if the project id is null
There was a problem hiding this comment.
Line below handles this condition
However, I agree that it's not very clear and it's not very readable
There was a problem hiding this comment.
oh i see
i'd wrap this in an if statement. the mixed up order is hard to read.
filter = { filter: {}};
if (this.project) {
filter.filter = { or: ...}
}
There was a problem hiding this comment.
Good idea, I am thinking something like this (word "like" is being used here because of type errors) using the filterOr helper
src/app/components/audio-analysis/pages/results/results.component.ts
Outdated
Show resolved
Hide resolved
| export const newScriptMenuItem = menuRoute({ | ||
| icon: defaultNewIcon, | ||
| label: "New Script", | ||
| route: scriptsMenuItem.route.add("new"), |
There was a problem hiding this comment.
You can access this route if you are an admin by navigating through
Admin dashboard > Scripts > New Script (in side bar)
There was a problem hiding this comment.
yeah but we don't have a view for it right?
There was a problem hiding this comment.
We do and it was automatically updated when the scripts.schema was updated
It doesn't have any of the fancy syntax highlighting that we want to do in the future, but it exists right now
I'll double check that it works as expected
Create read interface for analysis jobs
This pull request adds support for reading analysis jobs and scripts.
Both at the admin (site wide) and project level.
Changes
Outside of scope
This PR does not add a UI for provenance models
Issues
Fixes #2207
Visual Changes
Admin analysis job list view
Analysis job project details view
Admin script list view
Script details view
Final Checklist
npm run lint)npm run test:all)