Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created missing BAW services #227

Merged
merged 31 commits into from
May 5, 2020
Merged

Created missing BAW services #227

merged 31 commits into from
May 5, 2020

Conversation

Allcharles
Copy link
Contributor

Created missing BAW services

Implemented all of the known missing BAW services so that association loading can occur. This is also a precursor to the requirements for #191.

Changes

  • Created new services

Issues

  • Missing Analysis Results services
  • Haven't implemented custom routes (ie. /download)
  • Haven't verified all routes are functional on BAW server

Closes

Closes #219

Allcharles added 28 commits April 27, 2020 09:50
@Allcharles
Created analysis jobs service
1760afa
@Allcharles
Created audio event service
9c48e52
@Allcharles
Created audio event comment service
1c4a709
@Allcharles
Created bookmark service
64f16b0
@Allcharles
Created saved search service
458c009
@Allcharles
Created studies service
b944b59
@Allcharles
Created question services
a944dde
@Allcharles
Created response services
5fc5253
@Allcharles
Merge branch 'additional-services' into new-services
2437c11
@Allcharles
Extracted service tests to folder
3f3c9a3
@Allcharles
Created progress event services
9919fb7
@Allcharles
Created dataset services
1c8c537 
- Removed audio-event-comment service
- Cleanup ServiceTokens
- Cleanup testBawServices
@Allcharles
Cleanup AnalysisJob review comments
93f3e69 
Fix the following review comments:
- #190 (comment)
- #190 (comment)
- #190 (comment)
- #190 (comment)
- #190 (comment)
- #190 (comment)
@Allcharles
Cleanup AnalysisJobItem review comments
23dce4a 
Fix the following review comments:
- #190 (comment)
- #190 (comment)
- #190 (comment)
@Allcharles
Cleanup AudioEvent models review comments
0845eea 
Fix AudioEvent models review comments:
- #190 (comment)
- #190 (comment)
- #190 (comment)
@Allcharles
Cleanup AudioRecording review comments
78dfd4f 
Fix AudioRecording review comments:
- #190 (comment)
- #190 (comment)
- #190 (comment)
@Allcharles
Cleanup viewUrl review comments
41241be 
Cleanup viewUrl review comments:
- #190 (comment)
- #190 (comment)
- #190 (comment)
- #190 (comment)
- #190 (comment)
- #190 (comment)
- #190 (comment)
@Allcharles
Reduce persisted User keys
c9d6dfa 
Relates to the following comments:
- #190 (comment)
- #190 (comment)
@Allcharles
Cleanup missing associations
8e104be
@Allcharles
Cleanup AbstractModel test files
7e11dad 
- #223 (comment)
- #223 (comment)
@Allcharles
Convert model attributes to symbol
a8d8b91 
- #190 (comment)
- #223 (comment)
@Allcharles
Default account associations
cf246c7 
- #223 (comment)
@Allcharles
Created audio recording service
528ceb3
@Allcharles
Cleanup service declarations
f1591f7
@Allcharles
Created tagging service
4d60cad
@Allcharles
Created audio event tags service
af3947b
@Allcharles
Created AnalysisJobItem service
d4f2bc4
@Allcharles
Added model injectors
d87a7e5
@Allcharles Allcharles requested a review from atruskie April 30, 2020 04:18
@Allcharles Allcharles added the architecture Architectural changes to the software label Apr 30, 2020
@Allcharles Allcharles added the enhancement New feature or request label Apr 30, 2020
@Allcharles Allcharles linked an issue Apr 30, 2020 that may be closed by this pull request
Known Baw Services #219
Closed
22 tasks
atruskie
atruskie approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@atruskie atruskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are all tests for the services in a tests sub folder? This departs from established conventions?

I'd make a new issue for requested changes to SessionUser. This is otherwise good to go.

src/app/models/Response.ts Outdated Show resolved Hide resolved
src/app/models/User.ts Show resolved Hide resolved
src/app/services/baw-api/audio-event-tags.service.ts Show resolved Hide resolved
@Allcharles Allcharles changed the base branch from models to master May 5, 2020 04:07
@Allcharles Allcharles merged commit c0d4f6d into master May 5, 2020
@Allcharles Allcharles deleted the new-services branch May 5, 2020 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atruskie atruskie atruskie approved these changes

Assignees
No one assigned
Labels
architecture Architectural changes to the software enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Known Baw Services
2 participants
@Allcharles @atruskie