Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse NULL geometry #35

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Parse NULL geometry #35

merged 2 commits into from
Mar 15, 2024

Conversation

JosiahParry
Copy link
Collaborator

@JosiahParry JosiahParry commented Mar 15, 2024

This PR updates parse_esri_json(). It now

  • creates an empty geometry collection when a geometry is NULL
  • when 0 features are returned an empty data.frame with the correct fields and types is returned.
    • Note that this does not propagate to arc_select() because there is an additional check in there.
  • If an unknown geometry type is returned, an informative error is elicited via cli

Supported by new function ptype_tbl() which is a data.frame version of remote_ptype_tbl().

Closes R-ArcGIS/arcgislayers#168

@JosiahParry JosiahParry merged commit 1bfd01e into main Mar 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in geo_raw[[i]]: subscript out of bounds
1 participant