Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use GameInstall object for PR install functions #467

Merged
merged 1 commit into from
Aug 3, 2023
Merged

refactor: Use GameInstall object for PR install functions #467

merged 1 commit into from
Aug 3, 2023

Conversation

Jan200101
Copy link
Contributor

@Jan200101 Jan200101 commented Aug 3, 2023 •
edited by GeckoEidechse
Loading

Passes the whole GameInstall object instead of individual path to functions related to PR installs.

This is done in preparation for #444

@GeckoEidechse GeckoEidechse changed the title Game Path -> GameInstall migration Tres refactor: Use GameInstall object for PR install functions Aug 3, 2023
GeckoEidechse
GeckoEidechse approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by installing a random mods and launcher PR. The changed code should not affect any current logic. I checked to make sure that all relevant frontend functions that call that code are updated.

@GeckoEidechse GeckoEidechse merged commit e75f5f8 into R2NorthstarTools:main Aug 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jan200101 @GeckoEidechse