This repository has been archived by the owner on May 26, 2020. It is now read-only.
Update ReactiveSwift to 3.1 and ReactiveCocoa to 7.1 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-lukanta-ck
force-pushed
the
upgradeReactiveCocoaAndSwift
branch
2 times, most recently
from
cee2bdb
to
ad0fb58
Compare
james-lukanta-ck
force-pushed
the
upgradeReactiveCocoaAndSwift
branch
from
ad0fb58
to
7150ec1
Compare
ikesyo
reviewed
Apr 20, 2018
.travis.yml
Outdated
| before_install: | ||
| - brew uninstall carthage | ||
| - HOMEBREW_NO_AUTO_UPDATE=1 brew install https://raw.githubusercontent.com/Homebrew/homebrew-core/6ae4f69a652fb0ecb102b0c9216378679a4f1b92/Formula/carthage.rb # 0.22.0 | ||
| - HOMEBREW_NO_AUTO_UPDATE=1 brew install https://raw.githubusercontent.com/Homebrew/homebrew-core/45dd24d8dfa7a2fb69812c678ceb34be0c16e295/Formula/carthage.rb # 0.29.0 |
There was a problem hiding this comment.
This force upgrade should not be needed anymore. Could you please remove the before_install:?
|
@ikesyo Thanks for the feedback. I have incorporated your suggestion. This PR now passes all checks. Do you have any other suggestion? Otherwise, can I please get an approval? |
| @@ -102,7 +102,7 @@ extension ReactiveArray { | |||
| public mutating func replaceSubrange<C>(_ subrange: Range<Int>, with newElements: C) where C: Collection, C.Iterator.Element == Element { | |||
| elements.replaceSubrange(subrange, with: newElements) | |||
|
|
|||
| let elementsCount = Int(newElements.count.toIntMax()) | |||
| let elementsCount = newElements.count | |||
There was a problem hiding this comment.
toIntMax() is deprecated in Swift 4.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is needed to run
carthage update ReactiveCollectionson projects that use XCode 9.3 / Swift 4.1