-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.2.7 #153
Release 1.2.7 #153
Conversation
Fix compiling
Security updates
Added new plugins to RadarService and firebase-remote-configs.
Added dependencies for new google plugins
Replaced drawable resource for UNAVAILABLE status of plugins.
Add Polar plugins
Enable New Audio Plugin and Add Missing Polar Provider to Self-Release
Updated Radar-prmt to Target SDK 34 (Android 14)
"project_number": "250256119064", | ||
"firebase_url": "https://radar-cns-78f28.firebaseio.com", | ||
"project_id": "radar-cns-78f28", | ||
"storage_bucket": "radar-cns-78f28.appspot.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the google-services.json file was updated by Bastiaan. Was this intentional, or was it pushed by mistake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's by mistake. google-service.json shouldn't be there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more file, app/google-services.json, has been added as well.
gradle.properties
Outdated
|
||
# When configured, Gradle will run in incubating parallel mode. | ||
# This option should only be used with decoupled projects. More details, visit | ||
# http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects | ||
# org.gradle.parallel=true | ||
android.useAndroidX=true | ||
android.enableJetifier=true | ||
|
||
radar_commons_android_version=1.4.1-SNAPSHOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove this SNAPSHOT version and use the new version we are releasing for the commons-android library?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest release of radar-android-commons is 1.2.5. But I don't think it's the latest one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we release the radar-commons-android
library first with the contents of the dev
branch, which includes the Android 14 updates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update target SDK version to 34