-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search page refactor #110
Search page refactor #110
Conversation
…ow works with new search
I've tested locally, looks good, only one minor issue: Searching within a dataset and a vocabulary yields no result: The assumption here is a user would expect when ticking multiple Container instances, results can come from within any instance, not that the result must exist in all of them. I'd make the following recommendations for non-MVP enhancements:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments above
…avour searches with SearchBar; fixed query string re-rendering, renamed Advanced Search to Search
@recalcitrantsupplant thanks for the comments. What changes would you suggest for this MVP now? I could start by adding to the page that you can't select multiple container types. |
Just the one to restrict searching to one container type at present |
Added pagination using RDFLib/prez#159 |
The search page now uses the new search implementation outlined in RDFLib/prez#149.
Users can filter by a base class, containers, and can provide custom inbound & outbound filters.
Resolves #95, resolves #72.