Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels refactor, resource routes & testing frameworks #116

Merged
merged 9 commits into from
Nov 14, 2023

Conversation

jamiefeiss
Copy link
Collaborator

Replaced profile-driven label predicates with the list of annotation predicates retrieved from the root API endpoint, as in RDFLib/prez#164. Labels, descriptions & provenance are now retrieved using getAnnotation() and the convenience functions getLabel(), getDescription() & getProvenance().

Also refactored the types & props for PropTable.vue and its children components following the annotation predicates refactor.

Updated the routes for dcat:Resources in CatPrez to use the following routes:

  • /c/catalogs/<catalog_curie>/resources
  • /c/catalogs/<catalog_curie>/resources/<resource_curie>

Added some initial unit, component & end-to-end tests as well as benchmarking using the Vitest & Cypress testing frameworks.

Resolves #115.

@recalcitrantsupplant
Copy link
Collaborator

Haven't had a look at the test parts yet - visually checked the functionality and it looks fine.
If a link is not available for a resource it means there is no class information for it. At present the UI provides a link to the current page - which is probably not expected. We should have a think about what to do in this scenario - might be best to consider it incomplete data for the resource and not return it in the listing in the first place.

@edmondchuc
Copy link
Collaborator

Tested it locally with the ANU instance of catprez and it looks good!

@jamiefeiss jamiefeiss merged commit a9ba28a into main Nov 14, 2023
1 check passed
@jamiefeiss jamiefeiss deleted the feature/labels-refactor branch November 14, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use list of supported annotation predicates from API
3 participants