Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore pyrdfa #1503

Closed
wants to merge 11 commits into from
Closed

Restore pyrdfa #1503

wants to merge 11 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 13, 2021

Fix for #1390, “Bringing back RDFa support to RDFLib”.

Tactical decision required:

Follow the original approach and copy the pyRdfa and pyMicrodata sources into the RDFLib source tree
or
Add pyrdfa3==3.5.3 and git+https://github.com/RDFLib/pymicrodata.git#egg=pyMicrodata to requirements.

Also, it opens a bit of a can of worms in that using a wikipedia URL results in:

.../site-packages/urllib3/connectionpool.py:1013:
InsecureRequestWarning: Unverified HTTPS request is being made to host 'en.wikipedia.org'.
Adding certificate verification is strongly advised.
See: https://urllib3.readthedocs.io/en/1.26.x/advanced-usage.html#ssl-warnings

@ghost
Copy link
Author

ghost commented Dec 13, 2021

Dunno what's happening with drone, maybe I need to re-do the fork into my repos.

@ghost
Copy link
Author

ghost commented Dec 15, 2021

Tactical decision required:

Follow the original approach and copy the pyRdfa and pyMicrodata sources into the RDFLib source tree or Add pyrdfa3==3.5.3 and git+https://github.com/RDFLib/pymicrodata.git#egg=pyMicrodata to requirements.

Alternatively ... add pyrdfa3 to requirements to avoid mypy errors preventing drone build from succeeding.

Long-term, if RDFa capability is to be preserved, pyrdfa3 will need to be brought into mypy scope at some point.

@ghost ghost closed this Dec 29, 2021
@ghost ghost deleted the restore-pyrdfa branch December 29, 2021 15:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant