Convert to use cmake-js and pkg-prebuilds #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I still need to take a look at how to best work with #30. |
LandryNorris
commented
Oct 2, 2024
package.json
Outdated
| "test": "node --napi-modules test/test_binding.js" | ||
| "install": "pkg-prebuilds-verify binding-options.cjs || npm run build", | ||
| "build": "node scripts/download-CanBridge.mjs && cmake-js compile && tsc", | ||
| "prepublishOnly": "npm run build && pkg-prebuilds-copy --baseDir build/Release --source node_canbridge.node --name node_canbridge --napi_version=8", |
There was a problem hiding this comment.
Other platforms besides windows need baseDir set to build, if I imagine correctly
There was a problem hiding this comment.
https://github.com/Julusian/node-jpeg-turbo/blob/main/.github/workflows/node.yaml always uses build/Release
ItsHarper
suggested changes
Oct 2, 2024
…an-bridge into refactor/use-cmake-js
|
Please update the lockfile |
ItsHarper
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake has much better IDE support (allowing for development in VSCode and CLion). WPILib is also looking at moving C builds to CMake, so using it here may make pulling CANBridge and WPILib easier in the future.