Allow also posix and community.general Ansible modules
#279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,6 +55,8 @@ def process_task(task, all_allowed_modules): | |||
| found_allowed_modules.update(process_task(block_task, all_allowed_modules)) | |||
| else: | |||
| keywords = set(kw.replace('ansible.builtin.', '') for kw in original_keywords) | |||
| keywords = set(kw.replace('community.general.', '') for kw in keywords) | |||
There was a problem hiding this comment.
What about something like this:
keywords = set()
for kw in original_keywords:
keywords.add(re.sub(r'(ansible.builtin.|community.general.|ansible.posix.)', r'', kw))
There was a problem hiding this comment.
Changes 3 similar lines to 3 different lines and that's fine. But adds complexity and reduces readability. So I'd stay with my solution.
There was a problem hiding this comment.
It's probably pointless now, but maybe this would have been a reasonable alternative for avoiding the multiple iterations of keywords:
filters = lambda kw: (kw
.replace('ansible.builtin.', '')
.replace('community.general.', '')
.replace('ansible.posix.', '')
)
keywords = set(map(filters, original_keywords))(or a more traditional version with backslashes instead of wrapping the lambda body in ( )).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modules with these FQCN should be accepted as well, not just modules from
ansible.builtin.