Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle transaction lower than 1 #189

Closed
wants to merge 1 commit into from
Closed

Handle transaction lower than 1 #189

wants to merge 1 commit into from

Conversation

K-w-e
Copy link
Contributor

@K-w-e K-w-e commented Jan 4, 2025

Fixing #185

@theperu theperu added the bug Something isn't working label Jan 4, 2025
theperu
theperu approved these changes Jan 4, 2025
View reviewed changes
Copy link
Collaborator

@theperu theperu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job! 👍🏻

@K-w-e K-w-e closed this Jan 4, 2025
@K-w-e K-w-e deleted the bugfix/186 branch January 4, 2025 17:05
@theperu
Copy link
Collaborator

theperu commented Jan 4, 2025

@K-w-e why did you close the PR?

@K-w-e
Copy link
Contributor Author

K-w-e commented Jan 4, 2025

The branch name referred to a different issue. Renaming the branch deleted and recreated the pull request.

Sorry.

@theperu
Copy link
Collaborator

theperu commented Jan 4, 2025

Ok, no problem 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theperu theperu theperu approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@K-w-e @theperu