Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.6.0 #68

Merged
merged 11 commits into from
Sep 25, 2023
Merged

Version 1.6.0 #68

merged 11 commits into from
Sep 25, 2023

Conversation

pond
Copy link
Member

@pond pond commented Sep 25, 2023

Back-ports changes from #61, #62, #65 and #66 into V1, to be released as v1.6.0. Thanks @xjunior!

@pond pond added bug Something isn't working enhancement New feature or request labels Sep 25, 2023
@pond pond changed the base branch from main to v1 September 25, 2023 05:06
@@ -40,6 +40,7 @@ jobs:
- name: Install PostgreSQL client
run: |
sudo apt-get -yqq install libpq-dev

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by to minimise diff with V2.

@@ -6,6 +6,8 @@

A SCIM v2 API endpoint implementation for Ruby On Rails.

For a list of changes and information on major version upgrades, please see `CHANGELOG.md`.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by to minimise diff with V2.

@@ -25,7 +25,6 @@ class ApplicationController < ActionController::Base
#
# ...to "globally" invoke this handler if you wish.
#
#
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by to minimise diff with V2.

post 'Users', to: 'mock_users#create'
put 'Users/:id', to: 'mock_users#replace'
patch 'Users/:id', to: 'mock_users#update'
delete 'Users/:id', to: 'mock_users#destroy'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by to minimise diff with V2.

@pond
Copy link
Member Author

pond commented Sep 25, 2023

Diff looks good so I'm just going to expedite this - merging now.

@pond pond merged commit 9d08a0d into v1 Sep 25, 2023
@pond pond deleted the feature/v1.6.0 branch September 25, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants