Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #87, it's pointed out that the Address complex type has a default
type
ofwork
, which is unusual; such defaults were removed from other types in 19bab37.This PR removes the default, though we must exercise caution when releasing a version of Scimitar with the change included as it might be a breaking change for some clients.
(The release strategy is probably still to call it 2.7.0 as it's not clear if this would break anyone, but warn in the change log - hopefully that's sufficient.).