Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update doiuse #277

Closed
wants to merge 0 commits into from
Closed

feat: update doiuse #277

wants to merge 0 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 4, 2023

Closes #267

@ghost ghost mentioned this pull request Jul 4, 2023
@clshortfuse
Copy link

clshortfuse commented Jul 4, 2023

I took a look and it seems like a problem with eslint-plugin-import.

import-js/eslint-plugin-import#2703

The package is exporting everything as it should and works with require as specified by the NodeJS documentation.

I would suggest adding an ignore line, or move to https://github.com/eslint-community/eslint-plugin-n which IIRC does support the newer syntax.

Edit: I tested the n/no-missing-require rule and can confirm it properly recognizes the require('doiuse').

@ghost
Copy link
Author

ghost commented Jul 6, 2023

I took a look and it seems like a problem with eslint-plugin-import

Ah yeah you're right. I should have known, I've encountered this issue before. I'll fix it this week and then we should be good to go. Thanks for the quick reply.

@ghost ghost closed this Jul 7, 2023
@ghost ghost force-pushed the update-doiuse branch from 546b9c6 to f74796c Compare July 7, 2023 13:46
@ghost
Copy link
Author

ghost commented Jul 7, 2023

All right, released with v7 now. Thanks again for the quick feedback @clshortfuse!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alternative for doiuse?
1 participant