-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OCP FP8 formats #3399
Add OCP FP8 formats #3399
Conversation
CharlieL7
commented
Aug 23, 2024
•
edited
Loading
edited
- Enables/adds the F8E4M3FN and F8E5M2 data types
- Change to gpu::context value to be able to get the gfx name at quantization
- Update tests to also try the new data types
- rocBLAS does not support the OCP fp8 formats so converting the datatype before rocBLAS instructions
- hipBLASlt should have support and will need an update to the code later
- See Update MIGraphX FP8 to support OCP types #3393 for issue details
- Needs Handle the new F8 types in RockTuningImpl.cpp too. Oops. rocMLIR#1634 from rocMLIR to work fully on Navi4X
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3399 +/- ##
===========================================
- Coverage 92.07% 92.04% -0.04%
===========================================
Files 504 505 +1
Lines 20689 20699 +10
===========================================
+ Hits 19050 19052 +2
- Misses 1639 1647 +8 ☔ View full report in Codecov by Sentry. |
* these were previously disabled for fp8E4M3FNUZ, need to also disable for the new formats
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make the TODOs separate issues so we can track them.
I kicked off CI for the other build checks. Just ensure CI is working and you add tickets and I'll approve.
CI failure seems unrelated to your changes. Getting a lot of "Failed to fetch" errors. |
Approved.. I'll rekick CI but that MLIR issue seems like its server related and not build. |
This build is not recommended to merge 🔴 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |