update layernorm #1570
Open
update layernorm #1570
+860
−399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltqin
requested review from
junliume,
illsilin,
carlushuang,
aosewski,
poyenc,
geyyer,
bartekxk and
a team
as code owners
carlushuang
requested changes
Oct 13, 2024
There was a problem hiding this comment.
- API naming issue, we can't have
layernorm2d_fwd_fp16,layernorm2d_fwd_fp16. Need have a single APIlayernorm2d_fwdwhich is originally rocking version - need use
traitto dispatch API. This PR completely remove this p_mean,p_invStdremoved??
-> this PR need more change to merge to public
2. Move construction of tensor_view and tile_window to operator()
spolifroni-amd
previously approved these changes
Oct 15, 2024
rocking5566
force-pushed
the
letaoqin/update_layernorm
branch
from
e50e331
to
abe875d
Compare
rocking5566
force-pushed
the
letaoqin/update_layernorm
branch
from
9b64545
to
47396e2
Compare
rocking5566
force-pushed
the
letaoqin/update_layernorm
branch
from
47396e2
to
02b9a7d
Compare
rocking5566
force-pushed
the
letaoqin/update_layernorm
branch
from
02b9a7d
to
5c736bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.