Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default stride #1576

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Update default stride #1576

wants to merge 5 commits into from
+26 −26

Conversation

geyyer
Copy link
Contributor

@geyyer geyyer commented Oct 15, 2024 •
edited
Loading

  • Set default stride value to -1

@geyyer geyyer marked this pull request as ready for review October 16, 2024 14:20
@geyyer geyyer requested a review from hsadasiv October 16, 2024 14:20
hsadasiv
hsadasiv reviewed Oct 16, 2024
View reviewed changes
Copy link
Contributor

@hsadasiv hsadasiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the indentations/formatting problem in run_complex_contraction_bilinear_example.inc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsadasiv hsadasiv hsadasiv left review comments

@junliume junliume Awaiting requested review from junliume junliume is a code owner

@illsilin illsilin Awaiting requested review from illsilin illsilin is a code owner

@carlushuang carlushuang Awaiting requested review from carlushuang carlushuang is a code owner

@aosewski aosewski Awaiting requested review from aosewski aosewski is a code owner

@poyenc poyenc Awaiting requested review from poyenc poyenc is a code owner

@bartekxk bartekxk Awaiting requested review from bartekxk bartekxk is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geyyer @hsadasiv