[CK_TILE] Shrink lse_accum distributed tensor size in fmha splitkv combine kernel #1577
+69
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poyenc
requested review from
junliume,
illsilin,
carlushuang,
aosewski,
geyyer and
bartekxk
as code owners
qianfengz
reviewed
Oct 16, 2024
| constexpr index_t MThreads = kBlockSize / NThreads; | ||
| constexpr index_t MPerThread = kMPerBlock / MThreads; | ||
| constexpr index_t MThreadPerWarp = get_warp_size() / NThreads; | ||
| constexpr index_t MWarps = kMPerBlock / MThreadPerWarp; |
There was a problem hiding this comment.
MWarps = kMPerBlock / MThreadPerWarp ? Confusing, why not MWarps = kBlockSize / get_warp_size()
There was a problem hiding this comment.
because I'm using hard-coded kBlockSize=256, thus kBlockSize/ get_warp_size() (=4) will exceed the real # warp needed here if kMPerBlock is less than 64.
…ROCm/composable_kernel into feature/optimize-splitkv-combine-kernel
qianfengz
previously approved these changes
Oct 17, 2024
…ROCm/composable_kernel into feature/optimize-splitkv-combine-kernel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.