Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CK-Tile Grouped GEMM refactor and post PR fixes #1756

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

CK-Tile Grouped GEMM refactor and post PR fixes #1756

wants to merge 9 commits into from
+257 −349

Conversation

mozga-amd
Copy link
Contributor

This pull-request contains changes as following:

  • Standardizing the function naming,
  • Moving the get_stride function, etc., to a different location,
  • Generalizing the 1D partitioner function for general use and single responsibility,
  • Adding an offset function to calculate the shift.

@aosewski aosewski changed the title Apply refactor to universal gemm to bwd_weight_cshuffle CK-Tile Grouped GEMM refactor and post PR fixes Dec 18, 2024
aosewski
aosewski previously requested changes Dec 18, 2024
View reviewed changes
include/ck_tile/core/arch/arch.hpp Outdated Show resolved Hide resolved
include/ck_tile/core/arch/arch.hpp Show resolved Hide resolved
include/ck_tile/core/arch/arch.hpp Outdated Show resolved Hide resolved
include/ck_tile/core/arch/arch.hpp Outdated Show resolved Hide resolved
include/ck_tile/host/host_tensor.hpp Outdated Show resolved Hide resolved
include/ck_tile/ops/gemm/kernel/gemm_tile_partitioner.hpp Outdated Show resolved Hide resolved
include/ck_tile/ops/gemm/kernel/grouped_gemm_kernel.hpp Outdated Show resolved Hide resolved
include/ck_tile/ops/gemm/kernel/grouped_gemm_kernel.hpp Outdated Show resolved Hide resolved
include/ck_tile/ops/gemm/kernel/grouped_gemm_kernel.hpp Outdated Show resolved Hide resolved
include/ck_tile/ops/gemm/kernel/gemm_tile_partitioner.hpp Show resolved Hide resolved
@aosewski aosewski dismissed their stale review December 19, 2024 15:55

Will be off from tomorrow till 2nd Jan. Please pass on review to ie. @bartekxk

@mozga-amd mozga-amd requested a review from afagaj as a code owner January 5, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlushuang carlushuang carlushuang left review comments

@aosewski aosewski aosewski left review comments

@junliume junliume Awaiting requested review from junliume junliume is a code owner

@illsilin illsilin Awaiting requested review from illsilin illsilin is a code owner

@qianfengz qianfengz Awaiting requested review from qianfengz qianfengz is a code owner

@poyenc poyenc Awaiting requested review from poyenc poyenc is a code owner

@geyyer geyyer Awaiting requested review from geyyer geyyer is a code owner

@bartekxk bartekxk Awaiting requested review from bartekxk bartekxk is a code owner

@andriy-ca andriy-ca Awaiting requested review from andriy-ca andriy-ca is a code owner

@afagaj afagaj Awaiting requested review from afagaj afagaj is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mozga-amd @carlushuang @aosewski