Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize hipsparse header #461

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Reorganize hipsparse header #461

wants to merge 9 commits into from
+16,795 −14,044

Conversation

jsandham
Copy link
Contributor

Reorganize hipsparse header to it is more manageable.

  • Separates functions into their own header. This makes it easier to navigate and find functions and makes adding documentation and deprecation warnings more manageable. Follows similar to what we did in rocsparse.

cgmb
cgmb reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@cgmb cgmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no strong opinions on the end goal, but there's a few things to consider changing in the implementation details.

library/include/conversion/hipsparse_coo2csr.h Outdated Show resolved Hide resolved
library/CMakeLists.txt
@@ -35,8 +35,7 @@ configure_file("${CMAKE_CURRENT_SOURCE_DIR}/include/hipsparse-version.h.in"
"${PROJECT_BINARY_DIR}/include/hipsparse/hipsparse-version.h")

# Copy Header files to build directory
configure_file("${CMAKE_CURRENT_SOURCE_DIR}/include/hipsparse.h"
"${PROJECT_BINARY_DIR}/include/hipsparse/hipsparse.h" COPYONLY)
execute_process(COMMAND ${CMAKE_COMMAND} -E copy_directory "${CMAKE_CURRENT_SOURCE_DIR}/include" "${PROJECT_BINARY_DIR}/include/hipsparse")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

execute_process doesn't put any information into the generated Makefile about what input files affect what output files. I think this may break your incremental builds, as your headers will not get recopied when you change them.

library/include/conversion/hipsparse_bsr2csr.h Outdated Show resolved Hide resolved
@ntrost57
Copy link
Contributor

We will skip this on 6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgmb cgmb cgmb left review comments

@ntrost57 ntrost57 Awaiting requested review from ntrost57 ntrost57 is a code owner

@YvanMokwinski YvanMokwinski Awaiting requested review from YvanMokwinski YvanMokwinski is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsandham @ntrost57 @cgmb