Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try using ROCFFT_ROOT before trying ROCM_ROOT. #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Try using ROCFFT_ROOT before trying ROCM_ROOT. #33

wants to merge 2 commits into from
+16 −10

Conversation

malcolmroberts
Copy link
Contributor

No description provided.

gregrodgers
gregrodgers approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@gregrodgers gregrodgers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgmb
Copy link
Collaborator

cgmb commented Feb 28, 2023

Do you happen to recall the motivation for this change?

@malcolmroberts
Copy link
Contributor Author

Do you happen to recall the motivation for this change?

That was sure a while ago. As I recall, the issue is that one may be using a locally-installed rocFFT; this would be ignored if one looks for ROCM_ROOT before considering ROCFFT_ROOT.

@cgmb cgmb self-requested a review March 28, 2023 14:37
@cgmb cgmb self-assigned this Mar 28, 2023
@doctorcolinsmith
Copy link
Contributor

@cgmb to follow up on the merge conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregrodgers gregrodgers gregrodgers approved these changes

@cgmb cgmb Awaiting requested review from cgmb cgmb is a code owner

Assignees

@cgmb cgmb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@malcolmroberts @cgmb @doctorcolinsmith @gregrodgers