Handle get_omnitrace_is_preloaded() function called multiple times #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_omnitrace_is_preloaded() is called multiple times likely before the LD_PRELOAD environment variable is set to false in the code. The updated function sets a new environment variable once it finds that libomnitrace-dl.so has been loaded. Subsequent calls do not check for that libomnitrace-dl.so has been loaded after seeing that the OMNITRACE_DL_IS_PRELOADED environment variable is set to true. I have tested this code, and it runs fine, generating the trace results.