[MIGraphX EP] enable compilation and execution on Windows #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jeffdaily
requested changes
May 29, 2024
[MIGraphX EP] Fix provider options
|
I have no comment on the code, but @apwojcik the rocm6.xxx branches do not upstream. They are snap shots of upstream, so you may also need to post to onnxruntime for this change to stick around |
|
@apwojcik this looks good. Have you been able to get any inference on windows running with this? I've just quickly fixed a conflict from another changes that was added into the rocm6.2_internal_testing branch. |
|
Trying this now to compile and ensure nothing has changed for the linux ep side build. Only real change I see is you're using Policy "CMP0144" , as we're using cmake 3.26.4, and this requires atleast 3.27.x We'll have to update some more scripts on our end if that's the case. |
TedThemistokleous
requested changes
Jun 17, 2024
TedThemistokleous
approved these changes
Jun 17, 2024
TedThemistokleous
merged commit 69e234a
into
rocm6.2_internal_testing
12 of 14 checks passed
TedThemistokleous
added a commit
that referenced
this pull request
Jun 17, 2024
* enable MIGraphX EP on Windows * [MIGraphX EP] Fix provider options * fix formatting * unify the package name for both rocm and migraphx * fix compilation after moving to rocm6.2 * make STREAM_SYNC the default * workaround hip sdk bug on windows * Revert rename of private var for now --------- Co-authored-by: Filip Jankovic <[email protected]> Co-authored-by: Ted Themistokleous <[email protected]> Co-authored-by: Ted Themistokleous <[email protected]>
apwojcik
pushed a commit
that referenced
this pull request
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR changes CMake files and ONNXRUNTIME source code to enable the compilation of MIGraphX EP on Windows—key differences from the original implementation.
Microsoft Visual C++ 2022 compiler has been used to compile ONNXRT, including EP on Windows.