Remove CMP0144 for now as that requires cmake 3.27.0 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apwojcik
reviewed
Jul 8, 2024
| @@ -21,8 +21,8 @@ | |||
| # Add search paths for default rocm installation | |||
| list(APPEND CMAKE_PREFIX_PATH /opt/rocm/hcc /opt/rocm/hip /opt/rocm $ENV{HIP_PATH}) | |||
|
|
|||
| # Suppress the warning about the small capitals of the package name | |||
| cmake_policy(SET CMP0144 NEW) | |||
| # Suppress the warning about the small capitals of the package name - Enable when support to CMake 3.27.0 is used | |||
There was a problem hiding this comment.
Suggested change
| # Suppress the warning about the small capitals of the package name - Enable when support to CMake 3.27.0 is used | |
| if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.27) | |
| cmake_policy(SET CMP0144 NEW) | |
| endif() |
There was a problem hiding this comment.
I'm just going to comment this out for now.
apwojcik
approved these changes
Jul 8, 2024
TedThemistokleous
merged commit 479551b
into
ROCm:rocm6.2_internal_testing
5 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue with upstream requring CMake = 3.26.4 right now.
Motivation and Context
Keep things consistent with upstream onnxruntime