Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MIGraphX compilation for v1.19+ #48

Merged

Conversation

apwojcik
Copy link

Additionally, I added the fix for the warning on visibility: The local variable hides the class attribute.

Copy link

@TedThemistokleous TedThemistokleous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing build failures when I try to compile this. Did this work for you when you tried it?

 59%] Building CXX object CMakeFiles/onnxruntime_framework.dir/onnxruntime/onnxruntime/core/framework/onnxruntime_map_type_info.cc.o
[ 59%] Building CXX object CMakeFiles/onnxruntime_framework.dir/onnxruntime/onnxruntime/core/framework/onnxruntime_optional_type_info.cc.o
/onnxruntime/onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc: In lambda function:
/onnxruntime/onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc:1302:23: error: ‘struct migraphx::api::onnx_options’ has no member named ‘set_external_data_path’
 1302 |           cmp_options.set_external_data_path(model_path_.parent_path().string());

@TedThemistokleous TedThemistokleous added the bug Something isn't working label Jul 24, 2024
@apwojcik
Copy link
Author

Still seeing build failures when I try to compile this. Did this work for you when you tried it?

 59%] Building CXX object CMakeFiles/onnxruntime_framework.dir/onnxruntime/onnxruntime/core/framework/onnxruntime_map_type_info.cc.o
[ 59%] Building CXX object CMakeFiles/onnxruntime_framework.dir/onnxruntime/onnxruntime/core/framework/onnxruntime_optional_type_info.cc.o
/onnxruntime/onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc: In lambda function:
/onnxruntime/onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc:1302:23: error: ‘struct migraphx::api::onnx_options’ has no member named ‘set_external_data_path’
 1302 |           cmp_options.set_external_data_path(model_path_.parent_path().string());

You need recent MIGraphX from the develop branch to build MIGraphX EP. The branch release/rocm-rel-6.2 has that change incorporated, too.

Copy link

@TedThemistokleous TedThemistokleous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. Works off develop. Considering this will be bundled with ROCm 6.2 's MIGraphX this is a moot point now.

@TedThemistokleous TedThemistokleous merged commit bbb13c3 into rocm6.3_internal_testing Jul 24, 2024
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants