Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating to using hipDeviceMallocUncached #80

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Updating to using hipDeviceMallocUncached #80

wants to merge 1 commit into from
+8 −8

Conversation

gilbertlee-amd
Copy link
Collaborator

  • Switching to use the newer hipDeviceMallocUncached instead of hipDeviceMallocFinegrained

wenkaidu
wenkaidu reviewed Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@wenkaidu wenkaidu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add ROCm/HIP version check. Many folks working on Lockhart still use ROCm 5.5 and 5.6 etc.

@wenkaidu
Copy link
Collaborator

wenkaidu commented Jun 6, 2024

hipDeviceMallocUncached became available on and after ROCm 5.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenkaidu wenkaidu wenkaidu left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gilbertlee-amd @wenkaidu