Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memset to fix inflated performance when GPU is reset #94

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Memset to fix inflated performance when GPU is reset #94

wants to merge 2 commits into from
+2 −0

Conversation

mustafabar
Copy link

@mustafabar mustafabar commented Nov 8, 2024 •
edited
Loading

This PR addresses inflated bus BW values that are reported when the GPU memory is reset. Based on @gilbertlee-amd and confirmed by me

the problem is that we only initialize the first section of the subarray. The "shifted" sections are all using uninitialized memory - whatever the value of the GPU memory was.
When we do a GPU reset, this means that the value can be 0, which can ARTIFICIALLY inflate performance (because 0s can be send compressed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilbertlee-amd gilbertlee-amd Awaiting requested review from gilbertlee-amd

@nileshnegi nileshnegi Awaiting requested review from nileshnegi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mustafabar