Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change unroll for gfx94x #1186

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Change unroll for gfx94x #1186

wants to merge 1 commit into from

Conversation

wenkaidu
Copy link
Collaborator

Details

Do not mention proprietary info or link to internal work items in this PR.

Work item: "Internal", or link to GitHub issue (if applicable).

What were the changes?
Change unroll for gfx94x

Why were the changes made?
Improve RCCL performance when GPU clock is lower under heavy workload

How was the outcome achieved?
Increase unroll factor

Additional Documentation:

Approval Checklist

Do not approve until these items are satisfied.

  • Verify the CHANGELOG has been updated, if
    • there are any NCCL API version changes,
    • any changes impact library users, and/or
    • any changes impact any other ROCm library.

@wenkaidu wenkaidu added ci:extended gfx942 noCI Disable Jenkins for this PR. and removed ci:extended gfx942 labels Jun 4, 2024
@corey-derochie-amd
Copy link
Collaborator

Is this draft no longer valid @wenkaidu ?

@wenkaidu
Copy link
Collaborator Author

this is used to track SWDEV-469533 which still open in mainline build

@wenkaidu
Copy link
Collaborator Author

not intended for merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
noCI Disable Jenkins for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants