Calculate gpu_map for parseGraph if devIds != Ranks for NCCL_RINGS #1301
+22
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using NCCL_RINGS, parseGraph can fail if ROCR_VISIBLE_DEVICES is set. If the visible devices aren't consecutively numbered form 0, a gpu_map is needed .
This patch adds a check to build a gpu_map if NCCL_RINGS is set. The mapping retains GPU device number ordering, and should let users/developers easily explore RCCL performance over subsets of their system.
Users can use NCCL_RIGNS, where specified values correspond to RCCL 'ranks'
Falure with ROCM 6.1:
Expected results with proposed patch: