Make proxy dump print out more meaningful information. #1412
+22
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Proxy dump is a debugging tool to print out the current state and outstanding operations of the proxy. Proxy dump was not working properly prior to this patch. This PR made some modification to proxy dump code. This does not affect the communication logic in anyway.
Example:
Note that NCCL 2.23.4 made improvements in this area. We should revisit this when we eventually sync to that NCCL version.
This proves to be useful for debugging large scale job for us, and our partner are asking us to put this in as soon as possible.
Work item: : HPEXA-63 / LWPCOMMLIBS-559
What were the changes?
Change how proxy dump prints out information (added more info).
Why were the changes made?
This proxy dump is useful in debugging large scale multi-node hang.
How was the outcome achieved?
printf
Additional Documentation:
Note that NCCL 2.23.4 made improvements in this area. We should revisit this when we eventually sync to that NCCL version.
Proxy dump is not used in normal circumstance. This only affects debug instance when we set NCCL_DUMP_PROXY_SIGNAL.
Approval Checklist
Do not approve until these items are satisfied.