Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RCCL env params to control setting the SO_REUSEADDR and SO_LINGER socket options #1418

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

corey-derochie-amd
Copy link
Collaborator

Details

Work item: SWDEV-491354

What were the changes?
Added RCCL_SOCKET_REUSEADDR and RCCL_SOCKET_LINGER env params to control setting the SO_REUSEADDR and SO_LINGER socket options.

Why were the changes made?
This can allow control over the number of file descriptors created during bootstrapping.

How was the outcome achieved?
Conducted tests of FD count while repeatedly running AllReduce under the given test conditions, and saw a reduction with RCCL_SOCKET_LINGER=0 and =2, and a change in behaviour over time using RCCL_SOCKET_REUSEADDR=1.

Additional Documentation:
This is still under investigation.

Approval Checklist

Do not approve until these items are satisfied.

  • Verify the CHANGELOG has been updated, if
    • there are any NCCL API version changes,
    • any changes impact library users, and/or
    • any changes impact any other ROCm library.

…ER socket options. This can allow control over the number of file descriptors created during bootstrapping.
@corey-derochie-amd corey-derochie-amd self-assigned this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant