Fix required packages versioning rocm #2174
Open
+10
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… valid version check.
|
Is there any update on this PR? |
|
Could someone review this PR please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These minimal changes will ensure that both
FAKE_REQUIRED_PACKAGESandcollaborator_build REQUIRED_PACKAGESversions are valid regardless of the actual package version considering at most the patch version.This will fix the dependency check while installing the tensorflow-like packages like
tensorflow-rocmusing some package managers likepoetrysolving the issue I opened: #2161.If this PR will be accepted I think that the same changes can be done also in previous versions.
If some changes are needed feel free to notice that to me. I'll be glad to help.