Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MFMA][Test] Add scripts generating mfma related lit tests #472

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

binarman
Copy link

This PR adds scripts for lit test generation.

@binarman binarman marked this pull request as ready for review January 23, 2024 16:17
@alefimov-amd alefimov-amd changed the title [DRAFT][MFMA][Test] Add scripts generating mfma related lit tests [MFMA][Test] Add scripts generating mfma related lit tests Jan 23, 2024
@zhanglx13
Copy link

@binarman
I can see the value of auto test generator, especially for mfma instructions today and in the future. However, this script is just a one time thing unless you can integrate it into some cmake system so that such tests can be generated automatically when people do pip install triton for the first time. We can leave such work as triton onboard task. I don't expect to spend your time in this.
So since you already have the tests generated, should we close this PR?

@binarman
Copy link
Author

I agree that it would be good to integrate this script in cmake, but I did not update it too frequently, so I did not bother do an integration.

However I can not agree that this is one time thing, I've used this script to generate tests at least 3 times to this date(and regenerate them during debugging few more times):

@zhanglx13
Copy link

By "one time" I mean after the tests are generated, they live with the repo. And when people git clone our fork, they will have the tests and do not need to run the test-gen script to generate the tests again.
I can see you need to tweak it along the time. And you probably will in the future. I'll let you decide if you want to keep this PR.

@alefimov-amd
Copy link

I would like to merge this in triton-mlir.
I was thinking about reimplementing these tests (at least some of them) in gtest, so test and "ir generator" will be the same thing. But it requires some time so I think I'll do this in upstream.

This PR adds scripts for lit test generation.
@alefimov-amd alefimov-amd merged commit 6c88111 into ROCm:triton-mlir Mar 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants