-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add performance reference for important matmul kernels #642
base: main_perf
Are you sure you want to change the base?
Conversation
should we add the other perf-kernels as well, eg, FA fwd kernel ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are the purposes of this database file ? are they used to benchmark against the ref.csv ? if that's the case, what if the parameters changed, e.g GROUP_SIZE_M change from 4 to 8 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we may need other database file format if this is a daily/per commit tasks ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This database.yaml is used as the current best perf config. If you have an optimization that can improve the best perf number and requires a different config, we should update the database.
The main purpose is to catch regression.
Yes we should. I'll add FA related kernels later. |
db1424e
to
089b464
Compare
This PR adds a database of matmul configs that we want to keep track of their performance.
This PR also adds a reference performance collected on smc300x-ccs-aus-GPUF292 (MI300X).
The database and reference are serving two purposes: