Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More SPU patterns #15211

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

More SPU patterns #15211

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2c24389
Fix minus accuracy difference in spu_re_acc
RipleyTom Feb 14, 2024
f1399f6
Simplify spu patterns and fix sqrt pattern
RipleyTom Feb 15, 2024
1578d93
Add alternative reciprocal pattern
RipleyTom Feb 15, 2024
a4fae68
Further simplifications
RipleyTom Feb 15, 2024
2979c61
Change full_expr's scope
RipleyTom Feb 16, 2024
ef5cffd
Fixes
RipleyTom Feb 16, 2024
54ce134
Dynamic sqrt pattern
RipleyTom Feb 17, 2024
2b96a3e
More patterns
RipleyTom Feb 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 37 additions & 8 deletions rpcs3/Emu/Cell/SPULLVMRecompiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6051,12 +6051,41 @@ class spu_llvm_recompiler : public spu_recompiler_base, public cpu_translator
if (check_sqrt_pattern_for_float(ONEISH))
return;

// Generate dynamic pattern for when float is unknown because of scope
if (auto [ok_fma, cursed_float] = match_expr(full_expr, fma(fnms(spu_rsqrte(x), c, MT), fm(fsplat<f32[4]>(0.5f), c), c)); ok_fma)
// Generate dynamic pattern for when floats are unknown because of scope
if (auto [ok_fma, fnms_float, fm_float] = match_expr(full_expr, fma(fnms(spu_rsqrte(x), c, MT), fm(MT, c), c)); ok_fma)
{
erase_stores(a, b, c);
const auto bitcast_float = bitcast<u32[4]>(cursed_float);
set_vr(op.rt4, select(bitcast_float == splat<u32[4]>(0x3F800000) | bitcast_float == splat<u32[4]>(0x3F800001), fsqrt(fabs(x)), fma(fnms(spu_rsqrte(x), c, cursed_float), fm(fsplat<f32[4]>(0.5f), fm(x, spu_rsqrte(x))), fm(x, spu_rsqrte(x)))));
const auto bitcast_float = bitcast<u32[4]>(fnms_float);
set_vr(op.rt4, select(fcmp_uno(fm_float == fsplat<f32[4]>(0.5f)) & (bitcast_float == splat<u32[4]>(0x3F800000) | bitcast_float == splat<u32[4]>(0x3F800001)), fsqrt(fabs(x)), fma(fnms(spu_rsqrte(x), c, fnms_float), fm(fm_float, fm(x, spu_rsqrte(x))), fm(x, spu_rsqrte(x)))));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

select evaluates all its arguments, its why it exists (so it would be branch-less)
So this would perform worse.
You can use conditional jumps

return;
}
}

if (auto [ok_c, x] = match_expr(c, spu_rsqrte(MT)); ok_c)
{
auto check_accurate_resqrt_for_float = [&](f32 float_value) -> bool
{
if (auto [ok_fma] = match_expr(full_expr, fma(fnms(fm(c, c), x, fsplat<f32[4]>(float_value)), fm(fsplat<f32[4]>(0.5f), c), c)); ok_fma)
{
erase_stores(a, b, c);
set_vr(op.rt4, fsplat<f32[4]>(1.0f)/fsqrt(fabs(x)));
return true;
}
return false;
};

if (check_accurate_resqrt_for_float(1.0f))
return;

if (check_accurate_resqrt_for_float(ONEISH))
return;

// Generate dynamic pattern for when floats are unknown because of scope
if (auto [ok_fma, fnms_float, fm_float] = match_expr(full_expr, fma(fnms(fm(c, c), x, MT), fm(MT, c),c)); ok_fma)
{
erase_stores(a, b, c);
const auto bitcast_float = bitcast<u32[4]>(fnms_float);
set_vr(op.rt4, select(fcmp_uno(fm_float == fsplat<f32[4]>(0.5f)) & (bitcast_float == splat<u32[4]>(0x3F800000) | bitcast_float == splat<u32[4]>(0x3F800001)), fsplat<f32[4]>(1.0f)/fsqrt(fabs(x)), fma(fnms(fm(spu_rsqrte(x), spu_rsqrte(x)), x, fnms_float), fm(fm_float, spu_rsqrte(x)), spu_rsqrte(x))));
return;
}
}
Expand All @@ -6082,12 +6111,12 @@ class spu_llvm_recompiler : public spu_recompiler_base, public cpu_translator
if (check_accurate_reciprocal_pattern_for_float(ONEISH))
return;

// Generate dynamic pattern for when float is unknown because of scope
if (auto [ok_fma, cursed_float] = match_expr(full_expr, fma(fnms(div, c, MT), c, c)); ok_fma)
// Generate dynamic pattern for when floats are unknown because of scope
if (auto [ok_fma, fnms_float] = match_expr(full_expr, fma(fnms(div, c, MT), c, c)); ok_fma)
{
erase_stores(a, b, c);
const auto bitcast_float = bitcast<u32[4]>(cursed_float);
set_vr(op.rt4, select(bitcast_float == splat<u32[4]>(0x3F800000) | bitcast_float == splat<u32[4]>(0x3F800001), re_accurate(div), fma(fnms(spu_re(div), div, cursed_float), spu_re(div), spu_re(div))));
const auto bitcast_float = bitcast<u32[4]>(fnms_float);
set_vr(op.rt4, select(bitcast_float == splat<u32[4]>(0x3F800000) | bitcast_float == splat<u32[4]>(0x3F800001), re_accurate(div), fma(fnms(spu_re(div), div, fnms_float), spu_re(div), spu_re(div))));
return;
}
}
Expand Down