make all uses of forward labels count as non-static

src/asar/asar_math.cpp

@@ -22,7 +22,10 @@ static double eval(int depth);
 //userfunction
 
 bool foundlabel;
+// WARNING: this flag is only correctly set in pass 0, as forward labels are
+// always non-static but we don't know when we hit forward-labels past pass 0
 bool foundlabel_static;
+// only set in pass 0
 bool forwardlabel;
 
 struct cachedfile {
@@ -821,7 +824,10 @@ static double getnumcore()
 			}
 
 			str=start;
-			if (i==-1) forwardlabel=true;
+			if (i==-1) {
+				foundlabel_static = false;
+				forwardlabel=true;
+			}
 			return (int)i&0xFFFFFF;
 		}
 	}

src/asar/assembleblock.cpp

@@ -1086,7 +1086,7 @@ void assembleblock(const char * block, int& single_line_for_tracker)
 		if(!is("for"))
 		{
 			cond = getnum(word[1]);
-			if (foundlabel && !foundlabel_static && !is("assert")) asar_throw_error(1, error_type_block, error_id_label_in_conditional, word[0]);
+			if (foundlabel && !foundlabel_static && !is("assert")) asar_throw_error(0, error_type_block, error_id_label_in_conditional, word[0]);
 		}
 
 		if (is("for"))
@@ -1582,6 +1582,10 @@ void assembleblock(const char * block, int& single_line_for_tracker)
 			base = getnum(word[2]);
 
 			if (foundlabel && !foundlabel_static) static_struct = false;
+			if (pass > 0) {
+				// foundlabel_static isn't accurate anymore
+				static_struct &= structs.find(word[1]).is_static;
+			}
 		}
 
 		bool old_in_struct = in_struct;

tests/labels_static_fail.asm

@@ -1,15 +1,15 @@
+;`errElabel_in_conditional
+;`errElabel_in_conditional
+;`errElabel_in_conditional
+;`errElabel_in_conditional
+;`errElabel_in_conditional
 ;`errEno_labels_here
 ;`errEno_labels_here
 ;`errElabel_cross_assignment
 ;`errEno_labels_here
 ;`errEno_labels_here
 ;`errEno_labels_here
 ;`errEdefine_label_math
-;`errElabel_in_conditional
-;`errElabel_in_conditional
-;`errElabel_in_conditional
-;`errElabel_in_conditional
-;`errElabel_in_conditional
 org $008000
 ANonStaticLabel: