Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asar-tests: fix build with musl #311

Closed
wants to merge 1 commit into from

Conversation

orbea
Copy link
Contributor

@orbea orbea commented Mar 2, 2024

Trivial build fix for musl systems, this is a standard header and it should be safe to include everywhere even if the libc implicitly includes it already.

src/asar-tests/test.cpp: In function 'int main(int, char**)':
src/asar-tests/test.cpp:958:57: error: 'int64_t' was not declared in this scope
  958 |          test_status &= (int64_t)asar_math("1+0", &error_buffer) == 1;
      |                          ^~~~~~~

src/asar-tests/test.cpp: In function 'int main(int, char**)':
src/asar-tests/test.cpp:958:57: error: 'int64_t' was not declared in this scope
  958 |          test_status &= (int64_t)asar_math("1+0", &error_buffer) == 1;
      |                          ^~~~~~~
@randomdude999 randomdude999 changed the base branch from asar_2_beta to asar_19 March 2, 2024 07:36
@randomdude999 randomdude999 changed the base branch from asar_19 to asar_2_beta March 2, 2024 07:37
@randomdude999
Copy link
Collaborator

same comment as the other tests PR

ughhhhhh okay i don't know how to use github i guess. i'll cherry-pick this into 1.9 manually

@orbea
Copy link
Contributor Author

orbea commented Mar 2, 2024

ughhhhhh okay i don't know how to use github i guess. i'll cherry-pick this into 1.9 manually

The failure only happens with asar_2_beta fwiw.

@randomdude999
Copy link
Collaborator

well i suppose i better get on with deleting that code then

interestingly, we do have CI running on my raspberry pi with alpine, which uses musl, so it's weird that it didn't show up there (maybe gcc still uses glibc headers or something??)

@orbea orbea deleted the asar-tests-musl branch March 3, 2024 01:26
@orbea
Copy link
Contributor Author

orbea commented Mar 3, 2024

That is strange, I have musl 1.2.4 so maybe its a difference in the version? Regardless int64_t is clearly defined as requiring stdint.h/cstdint.

https://pubs.opengroup.org/onlinepubs/009695399/basedefs/stdint.h.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants