Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gradle to 5.3.1 #11

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Upgrade gradle to 5.3.1 #11

wants to merge 3 commits into from

Conversation

xdy
Copy link

@xdy xdy commented Jan 12, 2020

See commits for details. (I accidentally made, and closed, a PR towards master, ignore that one.)


This change is Reviewable

Includes tangentially related:
* Upgrading grgit to 4.0.1 to support newer gradle
* Switching from findbugs to spotbugs to get rid of deprecation warning
* Reformatting according to new spotless version

Other version updates will be done in a separate PR later. (Including suggesting a move to the build-in googleJavaFormat() to get google code format for spotless.)
This is *really* tangential so in it's own commit, but I wanted it for my branch so figured I'd include it.
```
./gradlew wrapper --gradle-version 5.3.1 --distribution-type all
```
Works withouht this commit, but this way the gradle files are stock.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant