Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max selectroot and nroot #135

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Max selectroot and nroot #135

merged 3 commits into from
Dec 28, 2023

Conversation

kohei-noda-qcrg
Copy link
Member

このプルリクは何?

プルリクの内容を記述してください

  • nrootおよびselectrootの設定できる最大値を500に制限しました
    • アウトプットが大量になることを防ぐため
  • READMEにもその旨記載しました

範囲を超過したインプットを設定すると以下のようなメッセージが表示されてプログラムが異常終了します

 ERROR: Your input is out of range. option_name: nroot
 input:                   501
 minimum allowed value:                     1
 maximum allowed value:                   500
 ERROR: Error in input, failed to read or validate an integer!!. Stop the progra
 m.
 input: 501

実装の内容

実装の内容を記述してください

(optional) 考慮事項

起こりうるバグなどがわかっている場合記述してください

@kohei-noda-qcrg kohei-noda-qcrg added the bug Something isn't working label Dec 27, 2023
@kohei-noda-qcrg kohei-noda-qcrg merged commit 9423804 into main Dec 28, 2023
14 checks passed
@kohei-noda-qcrg kohei-noda-qcrg deleted the max-selectroot-and-nroot branch December 28, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minoria-hiroshima minoria-hiroshima minoria-hiroshima approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kohei-noda-qcrg @minoria-hiroshima