Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom target and command to retrieve git commit hash #151

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

kohei-noda-qcrg
Copy link
Member

このプルリクは何?

プルリクの内容を記述してください

実装の内容

実装の内容を記述してください

(optional) 考慮事項

起こりうるバグなどがわかっている場合記述してください

  • https://stackoverflow.com/a/43206544 にあるように、ビルドターゲットをデフォルト以外にされるとコミットハッシュの取得処理が走らない。ただし本プロジェクトでは使用しないはずなので、ビルドターゲットを変更された場合の処理は加えていない。
    • プログラムがさらに複雑になった場合に対応を考える

@kohei-noda-qcrg kohei-noda-qcrg added the bug Something isn't working label Feb 23, 2024
@kohei-noda-qcrg kohei-noda-qcrg merged commit 55da746 into main Feb 28, 2024
14 checks passed
@kohei-noda-qcrg kohei-noda-qcrg deleted the fix-version-commit-hash branch February 28, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants